Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: validate env templates #3591

Merged
merged 3 commits into from Nov 24, 2022
Merged

fix: validate env templates #3591

merged 3 commits into from Nov 24, 2022

Conversation

caarlos0
Copy link
Member

ignore invalid environment variables (e.g. no key, no value, or no equal sign)

Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
@caarlos0 caarlos0 self-assigned this Nov 24, 2022
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 24, 2022
@caarlos0 caarlos0 added the bug Something isn't working label Nov 24, 2022
@vercel vercel bot temporarily deployed to Preview November 24, 2022 19:09 Inactive
@codecov
Copy link

codecov bot commented Nov 24, 2022

Codecov Report

Merging #3591 (ad52cb2) into main (9abc613) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head ad52cb2 differs from pull request most recent head 4ba8cee. Consider uploading reports for the commit 4ba8cee to get more accurate results

@@           Coverage Diff           @@
##             main    #3591   +/-   ##
=======================================
  Coverage   83.87%   83.87%           
=======================================
  Files         117      117           
  Lines        9750     9751    +1     
=======================================
+ Hits         8178     8179    +1     
  Misses       1268     1268           
  Partials      304      304           
Impacted Files Coverage Δ
internal/tmpl/tmpl.go 97.84% <100.00%> (+0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caarlos0
Copy link
Member Author

not really sure this is needed btw

@caarlos0 caarlos0 merged commit a1305d3 into main Nov 24, 2022
@caarlos0 caarlos0 deleted the tmpl-env branch November 24, 2022 20:12
@github-actions github-actions bot added this to the v1.14.0 milestone Nov 24, 2022
@vercel vercel bot temporarily deployed to Preview November 24, 2022 20:13 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant