Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deprecate replacements #3589

Merged
merged 9 commits into from Nov 25, 2022
Merged

feat: deprecate replacements #3589

merged 9 commits into from Nov 25, 2022

Conversation

caarlos0
Copy link
Member

@caarlos0 caarlos0 commented Nov 24, 2022

The replacements thing was always a bit weird, especially on archives.

We can solve that with templates, so, removing I'm deprecating it.

Also did the same on other places that had it the same feature.

Closes #3588

Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
@caarlos0 caarlos0 self-assigned this Nov 24, 2022
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 24, 2022
@vercel vercel bot temporarily deployed to Preview November 24, 2022 13:55 Inactive
@codecov
Copy link

codecov bot commented Nov 24, 2022

Codecov Report

Merging #3589 (332f528) into main (f3f1c08) will decrease coverage by 0.05%.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##             main    #3589      +/-   ##
==========================================
- Coverage   83.87%   83.81%   -0.06%     
==========================================
  Files         117      117              
  Lines        9750     9770      +20     
==========================================
+ Hits         8178     8189      +11     
- Misses       1268     1274       +6     
- Partials      304      307       +3     
Impacted Files Coverage Δ
cmd/init.go 73.52% <0.00%> (ø)
pkg/config/config.go 95.21% <ø> (ø)
internal/pipe/nfpm/nfpm.go 93.53% <25.00%> (-0.77%) ⬇️
internal/pipe/snapcraft/snapcraft.go 84.26% <40.00%> (-0.79%) ⬇️
internal/pipe/archive/archive.go 92.76% <57.14%> (-1.15%) ⬇️
internal/builders/golang/build.go 79.80% <100.00%> (ø)
internal/exec/exec.go 84.55% <100.00%> (-0.12%) ⬇️
internal/http/http.go 87.54% <100.00%> (+0.08%) ⬆️
internal/pipe/aur/aur.go 80.20% <100.00%> (ø)
internal/pipe/brew/brew.go 83.16% <100.00%> (ø)
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@vercel vercel bot temporarily deployed to Preview November 24, 2022 17:36 Inactive
@caarlos0 caarlos0 added the enhancement New feature or request label Nov 24, 2022
@caarlos0 caarlos0 marked this pull request as ready for review November 24, 2022 17:38
caarlos0 added a commit that referenced this pull request Nov 24, 2022
added new `title` template function.


extracted from #3589

Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
@vercel vercel bot temporarily deployed to Preview November 24, 2022 18:39 Inactive
Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
@vercel vercel bot temporarily deployed to Preview November 24, 2022 18:44 Inactive
@vercel vercel bot temporarily deployed to Preview November 24, 2022 19:00 Inactive
@caarlos0 caarlos0 changed the title feat: deprecate replacements, add title tmpl feat: deprecate replacements Nov 24, 2022
Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
@vercel vercel bot temporarily deployed to Preview November 24, 2022 23:30 Inactive
Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
@vercel vercel bot temporarily deployed to Preview November 25, 2022 00:42 Inactive
@vercel vercel bot temporarily deployed to Preview November 25, 2022 02:37 Inactive
@caarlos0 caarlos0 merged commit e546564 into main Nov 25, 2022
@caarlos0 caarlos0 deleted the replacements branch November 25, 2022 18:26
@github-actions github-actions bot added this to the v1.14.0 milestone Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose original non-replaced single artifact fields
1 participant