Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support mTLS with client certificate when configured. #3302

Merged
merged 9 commits into from Aug 12, 2022

Conversation

scr-oath
Copy link
Contributor

  • Support artifactory servers that use mTLS to authorize
  • Add configuration and re-run the schema generation
  • Add a test case that uploads with a test certificate

@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 10, 2022
Copy link
Member

@caarlos0 caarlos0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, can you also update the docs related to this?

from the top of my head:

  • artifactory.md
  • upload.md

Thanks!

pkg/config/config.go Outdated Show resolved Hide resolved
@pull-request-size pull-request-size bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 10, 2022
@scr-oath scr-oath requested a review from caarlos0 August 10, 2022 19:43
@scr-oath
Copy link
Contributor Author

scr-oath commented Aug 10, 2022

lgtm, can you also update the docs related to this?

from the top of my head:

  • artifactory.md
  • upload.md

Thanks!

Great, I added information to both of those, and also added a Pipfile, Pipfile.lock, and README.md to www to show how to iterate with mkdocs serve while documenting.

💡Perhaps a task entry could be written to help with that too? But I'd love it if that could be a follow up as I'm not terribly familiar with task.

@caarlos0
Copy link
Member

No need to commit those, I iterate locally with Docker... there is a task for it already as well:

https://github.com/goreleaser/goreleaser/blob/main/Taskfile.yml#L103

@scr-oath
Copy link
Contributor Author

scr-oath commented Aug 11, 2022

No need to commit those, I iterate locally with Docker... there is a task for it already as well:

https://github.com/goreleaser/goreleaser/blob/main/Taskfile.yml#L103

I just tried it - nice that it exists, but it's so very slow on M1 mac.

WARNING: The requested image's platform (linux/amd64) does not match the detected host platform (linux/arm64/v8) and no specific platform was requested

I'll just remove the files and/or rejigger to include info on using docs:serve task target - for a seldom task, being a little slow isn't the end of the world.

EDIT

man, each change takes roughly 2m to render… I really think that the local solution is useful - this is NOT the same spirt of iteration that I was hoping for (and experienced) when using native python.

I added documentation for any fellow M1 or M2 Mac owners out there for how to build the docker image - I don't notice any difference of that vs the local python like I did for the default intel docker image.

@pull-request-size pull-request-size bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 11, 2022
@codecov
Copy link

codecov bot commented Aug 11, 2022

Codecov Report

Merging #3302 (3e7a98b) into main (1dd03ce) will decrease coverage by 0.12%.
The diff coverage is 40.62%.

@@            Coverage Diff             @@
##             main    #3302      +/-   ##
==========================================
- Coverage   84.27%   84.15%   -0.13%     
==========================================
  Files         116      116              
  Lines        9316     9332      +16     
==========================================
+ Hits         7851     7853       +2     
- Misses       1184     1194      +10     
- Partials      281      285       +4     
Impacted Files Coverage Δ
pkg/config/config.go 95.18% <ø> (ø)
internal/http/http.go 87.45% <40.62%> (-4.57%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caarlos0
Copy link
Member

hmm, I always use it on linux/amd64

hopefully this helps squidfunk/mkdocs-material#4240

@caarlos0 caarlos0 merged commit 53ed816 into goreleaser:main Aug 12, 2022
@github-actions github-actions bot added this to the 1.11.0 milestone Aug 12, 2022
@scr-oath scr-oath deleted the support-client-cert branch September 27, 2022 04:00
scr-oath added a commit to scr-oath/goreleaser that referenced this pull request Sep 27, 2022
scr-oath added a commit to scr-oath/goreleaser that referenced this pull request Sep 27, 2022
Fixing schema change from goreleaser#3302

Signed-off-by: Sheridan C Rawlins <scr@yahooinc.com>
@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants