Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: strip_parent_binary_folder #3261

Merged
merged 4 commits into from Aug 16, 2022
Merged

feat: strip_parent_binary_folder #3261

merged 4 commits into from Aug 16, 2022

Conversation

caarlos0
Copy link
Member

@caarlos0 caarlos0 commented Jul 28, 2022 •
edited

closes #3215

@caarlos0
feat: strip_parent_binary_folder
ae108b1 
Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
@caarlos0 caarlos0 self-assigned this Jul 28, 2022
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 28, 2022
@vercel vercel bot temporarily deployed to Preview July 28, 2022 01:20 Inactive
@caarlos0 caarlos0 mentioned this pull request Jul 28, 2022
Closed
2 tasks
@caarlos0 caarlos0 added the enhancement New feature or request label Jul 28, 2022
@caarlos0 caarlos0 marked this pull request as ready for review July 28, 2022 01:21
@codecov
Copy link

codecov bot commented Jul 28, 2022 •
edited

Codecov Report

Merging #3261 (a83ccb8) into main (6708031) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #3261   +/-   ##
=======================================
  Coverage   84.28%   84.28%           
=======================================
  Files         116      116           
  Lines        9313     9317    +4     
=======================================
+ Hits         7849     7853    +4     
  Misses       1183     1183           
  Partials      281      281
Impacted Files Coverage Δ
pkg/config/config.go 95.18% <ø> (ø)
internal/pipe/archive/archive.go 93.83% <100.00%> (+0.11%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us.

@caarlos0
docs: clarify dir
57ed154 
Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
@vercel vercel bot temporarily deployed to Preview July 28, 2022 12:44 Inactive
@vercel vercel bot temporarily deployed to Preview August 7, 2022 15:25 Inactive
@caarlos0
fix: fmt
a83ccb8 
Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
@vercel vercel bot temporarily deployed to Preview August 7, 2022 15:26 Inactive
@caarlos0 caarlos0 merged commit 4da595e into main Aug 16, 2022
@caarlos0 caarlos0 deleted the strip branch August 16, 2022 01:53
@github-actions github-actions bot added this to the 1.11.0 milestone Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@caarlos0 caarlos0

Labels
enhancement New feature or request size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.11.0
Development

Successfully merging this pull request may close these issues.

Configure placement of binary in archive.
1 participant
@caarlos0