Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(archive): always strip parent if set #3256

Merged
merged 4 commits into from Jul 27, 2022
Merged

fix(archive): always strip parent if set #3256

merged 4 commits into from Jul 27, 2022

Conversation

caarlos0
Copy link
Member

@caarlos0 caarlos0 commented Jul 27, 2022 •
edited

closes #3255

nathanhammond and others added 2 commits July 27, 2022 05:41
@nathanhammond
Always strip parents.
b84daa3
@caarlos0
refactor: improve code a bit
ba6e658 
Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
@caarlos0 caarlos0 self-assigned this Jul 27, 2022
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 27, 2022
@caarlos0 caarlos0 changed the title refactor: improve code a bit fix(archive): always strip parent if set Jul 27, 2022
@vercel vercel bot temporarily deployed to Preview July 27, 2022 12:32 Inactive
@caarlos0 caarlos0 added the bug Something isn't working label Jul 27, 2022
@caarlos0
refactor: even simpler
fc70b54 
Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
@caarlos0
Merge remote-tracking branch 'origin/main' into strip-parents-always
517998f
@pull-request-size pull-request-size bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 27, 2022
@caarlos0 caarlos0 marked this pull request as ready for review July 27, 2022 12:36
@vercel vercel bot temporarily deployed to Preview July 27, 2022 12:37 Inactive
@caarlos0 caarlos0 merged commit 315935a into main Jul 27, 2022
@caarlos0 caarlos0 deleted the strip-parents-always branch July 27, 2022 12:55
@github-actions github-actions bot added this to the 1.11.0 milestone Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@caarlos0 caarlos0

Labels
bug Something isn't working size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.11.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@caarlos0 @nathanhammond