fix: brew formula class generation when using dots #3117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hat homebrew expects Signed-off-by: Corbin Phelps <corbin.phelps@bluemedora.com>
pull-request-size
bot
added
the
size/XS
caarlos0
changed the title
Codecov Report
@@ Coverage Diff @@
## main #3117 +/- ##
==========================================
- Coverage 84.66% 84.41% -0.25%
==========================================
Files 113 113
Lines 9273 9300 +27
==========================================
Hits 7851 7851
- Misses 1149 1176 +27
Partials 273 273
Continue to review full report at Codecov.
|
caarlos0
approved these changes
May 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #3116
Change homebrew class generation to match what homebrew expects based on Homebrew's code for generating class names.