Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: better handle docker skip errors #3107

Merged
merged 1 commit into from May 12, 2022
Merged

fix: better handle docker skip errors #3107

merged 1 commit into from May 12, 2022

Conversation

caarlos0
Copy link
Member

Otherwise it'll advise the link when its actually just skipping the run...

Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
@caarlos0 caarlos0 added the bug Something isn't working label May 12, 2022
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 12, 2022
@vercel vercel bot temporarily deployed to Preview May 12, 2022 13:32 Inactive
@codecov
Copy link

codecov bot commented May 12, 2022

Codecov Report

Merging #3107 (d10a0bc) into main (ceee425) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #3107   +/-   ##
=======================================
  Coverage   84.41%   84.41%           
=======================================
  Files         113      113           
  Lines        9295     9297    +2     
=======================================
+ Hits         7846     7848    +2     
  Misses       1176     1176           
  Partials      273      273           
Impacted Files Coverage Δ
internal/pipe/docker/docker.go 89.63% <100.00%> (+0.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ceee425...d10a0bc. Read the comment docs.

@caarlos0 caarlos0 merged commit bbade2d into main May 12, 2022
@caarlos0 caarlos0 deleted the docker-skip-handle branch May 12, 2022 17:44
@github-actions github-actions bot added this to the v1.9.0 milestone May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant