Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: nfpm deprecation on nfpm check #3087

Merged
merged 1 commit into from May 9, 2022
Merged

fix: nfpm deprecation on nfpm check #3087

merged 1 commit into from May 9, 2022

Conversation

caarlos0
Copy link
Member

@caarlos0 caarlos0 commented May 8, 2022

closes #3067

closes #3067

Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
@caarlos0 caarlos0 added the bug Something isn't working label May 8, 2022
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 8, 2022
@vercel vercel bot temporarily deployed to Preview May 8, 2022 02:52 Inactive
@codecov
Copy link

codecov bot commented May 8, 2022

Codecov Report

Merging #3087 (65d3116) into main (4cf566b) will decrease coverage by 0.03%.
The diff coverage is 57.14%.

@@            Coverage Diff             @@
##             main    #3087      +/-   ##
==========================================
- Coverage   84.57%   84.53%   -0.04%     
==========================================
  Files         112      112              
  Lines        9225     9223       -2     
==========================================
- Hits         7802     7797       -5     
- Misses       1149     1151       +2     
- Partials      274      275       +1     
Impacted Files Coverage Δ
internal/deprecate/deprecate.go 93.54% <ø> (-1.33%) ⬇️
internal/pipe/nfpm/nfpm.go 92.68% <57.14%> (-0.80%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cf566b...65d3116. Read the comment docs.

@caarlos0 caarlos0 merged commit f812d1b into main May 9, 2022
@caarlos0 caarlos0 deleted the deprecate branch May 9, 2022 00:13
@github-actions github-actions bot added this to the v1.9.0 milestone May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

goreleaser check does not report usage of deprecated config options
1 participant