Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve docker errors #3080

Merged
merged 3 commits into from May 3, 2022
Merged

feat: improve docker errors #3080

merged 3 commits into from May 3, 2022

Conversation

caarlos0
Copy link
Member

@caarlos0 caarlos0 commented May 2, 2022

Adding an error page with some more info to help debug issues.

Adding an error page with some more info to help debug issues.

Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
@caarlos0 caarlos0 self-assigned this May 2, 2022
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 2, 2022
@caarlos0 caarlos0 added enhancement New feature or request docs A problem or enhancement in documentation labels May 2, 2022
@caarlos0 caarlos0 marked this pull request as ready for review May 2, 2022 19:20
@vercel vercel bot temporarily deployed to Preview May 2, 2022 19:20 Inactive
Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
@vercel vercel bot temporarily deployed to Preview May 2, 2022 19:38 Inactive
Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
@vercel vercel bot temporarily deployed to Preview May 2, 2022 23:40 Inactive
@codecov
Copy link

codecov bot commented May 2, 2022

Codecov Report

Merging #3080 (69338bf) into main (e31c49d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #3080   +/-   ##
=======================================
  Coverage   84.56%   84.57%           
=======================================
  Files         112      112           
  Lines        9222     9225    +3     
=======================================
+ Hits         7799     7802    +3     
  Misses       1149     1149           
  Partials      274      274           
Impacted Files Coverage Δ
internal/pipe/docker/docker.go 89.52% <100.00%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e31c49d...69338bf. Read the comment docs.

@caarlos0 caarlos0 merged commit ea7a696 into main May 3, 2022
@caarlos0 caarlos0 deleted the docker branch May 3, 2022 01:05
@github-actions github-actions bot added this to the v1.9.0 milestone May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs A problem or enhancement in documentation enhancement New feature or request size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants