Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent folder collisions in builds and universal binaries #3063

Merged
merged 1 commit into from Apr 26, 2022

Conversation

caarlos0
Copy link
Member

@caarlos0 caarlos0 commented Apr 25, 2022

  • on universal binaries, use the build id instead of the binary name to
    create the folder in the dist folder
  • on builds, default the id the to the binary name instead of project
    name. The binary name already defaults to the project id if empty, so
    this should only prevent having to specify the id + binary name in
    some cases.

closes #3061

- on universal binaries, use the build id instead of the binary name to
  create the folder in the dist folder
- on builds, default the id the to the binary name instead of project
  name. The binary name already defaults to the project id if empty, so
  this should only prevent having to specify the id + binary name in
  some cases.

closes #3061

Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
@caarlos0 caarlos0 self-assigned this Apr 25, 2022
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 25, 2022
@vercel vercel bot temporarily deployed to Preview April 25, 2022 00:44 Inactive
@caarlos0 caarlos0 marked this pull request as ready for review April 25, 2022 00:44
@codecov
Copy link

codecov bot commented Apr 25, 2022

Codecov Report

Merging #3063 (8a51545) into main (41f7c3a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #3063   +/-   ##
=======================================
  Coverage   84.53%   84.53%           
=======================================
  Files         112      112           
  Lines        9199     9201    +2     
=======================================
+ Hits         7776     7778    +2     
  Misses       1149     1149           
  Partials      274      274           
Impacted Files Coverage Δ
internal/pipe/build/build.go 87.34% <100.00%> (ø)
internal/pipe/universalbinary/universalbinary.go 85.88% <100.00%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41f7c3a...8a51545. Read the comment docs.

@caarlos0 caarlos0 added the bug Something isn't working label Apr 25, 2022
@caarlos0 caarlos0 merged commit 5aeb8ac into main Apr 26, 2022
@caarlos0 caarlos0 deleted the build-folder-collision branch April 26, 2022 01:07
@github-actions github-actions bot added this to the v1.9.0 milestone Apr 26, 2022
caarlos0 added a commit that referenced this pull request May 11, 2022
refs #3098
refs #3063

Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Universal binaries clash between multiple ids when using the same name_template
1 participant