Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow to use .Path and .Name on universal binary post hooks #2891

Merged
merged 3 commits into from Feb 8, 2022

Conversation

caarlos0
Copy link
Member

@caarlos0 caarlos0 commented Feb 8, 2022

This allows the usage of {{ .Path }} and {{ .Name }} on post templates. Closes #2890

This allows the usage of `{{ .Path }}` and `{{ .Name }}` on post
templates.

Closes #2890
@caarlos0 caarlos0 self-assigned this Feb 8, 2022
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 8, 2022
@caarlos0 caarlos0 added the enhancement New feature or request label Feb 8, 2022
@caarlos0 caarlos0 marked this pull request as ready for review February 8, 2022 02:28
@codecov
Copy link

codecov bot commented Feb 8, 2022

Codecov Report

Merging #2891 (eab9d38) into main (5f30f36) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2891      +/-   ##
==========================================
+ Coverage   84.51%   84.53%   +0.01%     
==========================================
  Files         111      111              
  Lines        8872     8882      +10     
==========================================
+ Hits         7498     7508      +10     
  Misses       1105     1105              
  Partials      269      269              
Impacted Files Coverage Δ
internal/pipe/universalbinary/universalbinary.go 85.62% <100.00%> (+0.91%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f30f36...eab9d38. Read the comment docs.

@vercel vercel bot temporarily deployed to Preview February 8, 2022 02:40 Inactive
@vercel vercel bot temporarily deployed to Preview February 8, 2022 02:44 Inactive
@caarlos0 caarlos0 merged commit c457d8f into main Feb 8, 2022
@caarlos0 caarlos0 deleted the universal-bin-hooks branch February 8, 2022 14:44
@github-actions github-actions bot added this to the v1.5.0 milestone Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Universal Binary hooks missing build option template variables
1 participant