Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make --release-notes flags more deterministic #2888

Merged
merged 2 commits into from Feb 7, 2022
Merged

fix: make --release-notes flags more deterministic #2888

merged 2 commits into from Feb 7, 2022

Conversation

caarlos0
Copy link
Member

@caarlos0 caarlos0 commented Feb 7, 2022

if the a file is given, but is empty, leave the changelog empty (although it will be warned).

this makes whitespace-only and empty files have the same behavior.

Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
@caarlos0 caarlos0 self-assigned this Feb 7, 2022
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 7, 2022
@vercel vercel bot temporarily deployed to Preview February 7, 2022 00:58 Inactive
@caarlos0 caarlos0 added the bug Something isn't working label Feb 7, 2022
Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
@vercel vercel bot temporarily deployed to Preview February 7, 2022 00:59 Inactive
@caarlos0 caarlos0 marked this pull request as ready for review February 7, 2022 01:00
@codecov
Copy link

codecov bot commented Feb 7, 2022

Codecov Report

Merging #2888 (7142f6c) into main (456f8aa) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2888   +/-   ##
=======================================
  Coverage   84.51%   84.51%           
=======================================
  Files         111      111           
  Lines        8872     8872           
=======================================
  Hits         7498     7498           
  Misses       1105     1105           
  Partials      269      269           
Impacted Files Coverage Δ
internal/pipe/changelog/changelog.go 90.66% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 456f8aa...7142f6c. Read the comment docs.

@caarlos0 caarlos0 merged commit 5f30f36 into main Feb 7, 2022
@caarlos0 caarlos0 deleted the change branch February 7, 2022 01:09
@github-actions github-actions bot added this to the v1.5.0 milestone Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant