Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replace cobra with coral #2881

Merged
merged 2 commits into from Feb 4, 2022
Merged

feat: replace cobra with coral #2881

merged 2 commits into from Feb 4, 2022

Conversation

caarlos0
Copy link
Member

@caarlos0 caarlos0 commented Feb 4, 2022

replacing cobra with coral.

cobra is still an indirect dependency because of chglog. Will change that in the future.

Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
@caarlos0 caarlos0 self-assigned this Feb 4, 2022
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 4, 2022
@caarlos0 caarlos0 added the enhancement New feature or request label Feb 4, 2022
@codecov
Copy link

codecov bot commented Feb 4, 2022

Codecov Report

Merging #2881 (e020e07) into main (114c3a8) will not change coverage.
The diff coverage is 88.88%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2881   +/-   ##
=======================================
  Coverage   84.47%   84.47%           
=======================================
  Files         111      111           
  Lines        8849     8849           
=======================================
  Hits         7475     7475           
  Misses       1105     1105           
  Partials      269      269           
Impacted Files Coverage Δ
cmd/man.go 61.11% <50.00%> (ø)
cmd/docs.go 61.11% <66.66%> (ø)
cmd/build.go 97.69% <100.00%> (ø)
cmd/check.go 100.00% <100.00%> (ø)
cmd/init.go 73.52% <100.00%> (ø)
cmd/release.go 100.00% <100.00%> (ø)
cmd/root.go 100.00% <100.00%> (ø)
cmd/schema.go 58.06% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 114c3a8...e020e07. Read the comment docs.

@caarlos0 caarlos0 marked this pull request as ready for review February 4, 2022 18:12
Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
@vercel vercel bot temporarily deployed to Preview February 4, 2022 19:11 Inactive
@caarlos0 caarlos0 merged commit a5d3e7b into main Feb 4, 2022
@caarlos0 caarlos0 deleted the coral branch February 4, 2022 19:31
@github-actions github-actions bot added this to the v1.5.0 milestone Feb 4, 2022
@Moulick
Copy link

Moulick commented Sep 23, 2023

Did goreleaser switch to coral to reduce the dependencies on Viper? If so, Cobra 1.4.0 drops Viper.

https://github.com/muesli/coral#cobra-140
https://github.com/spf13/cobra/releases/tag/v1.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants