feat: allow to override build flags by goos/goarch/etc

[caarlos0]

refs #2829

allow to override ldflags et al based on the build target

TODO

• allow to template goos/goarch/etc to use it together with feat: expose runtime goos and goarch on templates and metadata #2859

[codecov]

Codecov Report

Merging #2860 (27df8d2) into main (9d481d4) will increase coverage by 84.45%.
The diff coverage is 81.81%.

@@            Coverage Diff            @@
##           main    #2860       +/-   ##
=========================================
+ Coverage      0   84.45%   +84.45%     
=========================================
  Files         0      111      +111     
  Lines         0     8837     +8837     
=========================================
+ Hits          0     7463     +7463     
- Misses        0     1105     +1105     
- Partials      0      269      +269     

Impacted Files	Coverage Δ
pkg/config/config.go	87.15% <ø> (ø)
internal/builders/golang/build.go	90.41% <81.81%> (ø)
internal/client/mock.go	87.27% <0.00%> (ø)
internal/pipe/teams/teams.go	52.00% <0.00%> (ø)
internal/pipe/docker/manifest.go	96.55% <0.00%> (ø)
pkg/archive/tar/tar.go	81.63% <0.00%> (ø)
internal/pipe/linkedin/linkedin.go	53.33% <0.00%> (ø)
internal/pipe/dist/dist.go	90.32% <0.00%> (ø)
internal/pipe/gomod/gomod.go	100.00% <0.00%> (ø)
pkg/archive/targz/targz.go	80.00% <0.00%> (ø)
... and 103 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d481d4...27df8d2. Read the comment docs.

[bflad]

Hey @caarlos0 👋 This looks like its going in the right direction, although I'm having a little trouble verifying it after installing from this branch. It seems to be losing all the build configuration in the go build command for me or not including the override configuration.

Configuration:

builds:
  - flags:
      - -trimpath
    goos:
      - darwin
      - freebsd
      - linux
      - windows
    goarch:
      - '386'
      - amd64
      - arm
      - arm64
    ignore:
      - goarch: arm
        goos: windows
      - goarch: arm64
        goos: freebsd
      - goarch: arm64
        goos: windows
    ldflags:
      - -s -w -X main.Version={{.Version}}
    mod_timestamp: '{{ .CommitTimestamp }}'
    # overrides:
    #   - goos: darwin
    #     goarch: amd64
    #     tags:
    #       - netcgo

Environment:

❯ go env GOOS          
darwin
❯ go env GOARCH
amd64

Command:

goreleaser build --snapshot --rm-dist --single-target --debug

v1.4.1 output:

      • running                   cmd=[go build -trimpath -ldflags=-s -w -X main.Version=v0.1.3-next -o /Users/bflad/src/github.com/bflad/terraform-provider-framework/dist/terraform-provider-framework_darwin_amd64/terraform-provider-framework .]

buildconf output (no overrides):

      • running                   cmd=[go build -trimpath -ldflags=-s -w -X main.Version=v0.1.3-next -o /Users/bflad/src/github.com/bflad/terraform-provider-framework/dist/terraform-provider-framework_darwin_amd64/terraform-provider-framework .]

buildconf output (with overrides uncommented, no goarm or gomips in override):

     • running                   cmd=[go build -ldflags= -o /Users/bflad/src/github.com/bflad/terraform-provider-framework/dist/terraform-provider-framework_darwin_amd64/terraform-provider-framework .]

buildconf output (with overrides uncommented and goarm: 6 and gomips: hardfloat in override):

      • running                   cmd=[go build -trimpath -ldflags=-s -w -X main.Version=v0.1.3-next -o /Users/bflad/src/github.com/bflad/terraform-provider-framework/dist/terraform-provider-framework_darwin_amd64/terraform-provider-framework .]

Not sure about the missing tags in the last one, but I'm wondering if

goreleaser/internal/builders/golang/build.go

Lines 57 to 62 in 3f593d7

	if len(build.Goarm) == 0 {
	build.Goarm = []string{"6"}
	}
	if len(build.Gomips) == 0 {
	build.Gomips = []string{"hardfloat"}
	}

has anything to do with the target matching.

[caarlos0]

pushed some changes... it should now merge overrides into the build values, so it won't loose configs anymore

also, you can now template the goos/goarch/etc on overrides as well, in which you can for example use {{ .Runtime.Goos }}

[bflad]

Looks like its now selecting and merging correctly 🎉 although I think the build command logic might still need some updates to ensure its checking the details/overrides 😄

[bflad]

This is working as I would anticipate! 🎉 Thanks so much.

Totally fine as something in the future: I'm also wondering if env should allow similar overrides since I don't believe it can be templated and setting CGO_ENABLED between platforms (or other go command environment variables) is a bit awkward. I understand that is more difficult to merge/manage in the code though and happy to submit a followup issue/pull request. 👍

[caarlos0]

This is working as I would anticipate! 🎉 Thanks so much.

🚀🚀🚀🚀

Totally fine as something in the future: I'm also wondering if env should allow similar overrides since I don't believe it can be templated and setting CGO_ENABLED between platforms (or other go command environment variables) is a bit awkward. I understand that is more difficult to merge/manage in the code though and happy to submit a followup issue/pull request. 👍

I was thinking the same... and maybe also other options... but I think that yes, at least for env, we should do it.

for envs the endeavor is slightly bigger, as we need to care for build hooks as well https://goreleaser.com/customization/build/#build-hooks

but I think we can work on it on a different PR once this one has better coverage and is merged