Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose runtime goos and goarch on templates and metadata #2859

Merged
merged 2 commits into from Feb 1, 2022

Conversation

caarlos0
Copy link
Member

Expose {{ .Runtime.Goos }} and {{ .Runtime.Goarch }}

refs #2829

@caarlos0 caarlos0 added the enhancement New feature or request label Jan 30, 2022
@caarlos0 caarlos0 self-assigned this Jan 30, 2022
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 30, 2022
@bflad
Copy link
Contributor

bflad commented Jan 31, 2022

This appears to be working as expected, at least with my testing of build tags. 👍

Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
@vercel vercel bot temporarily deployed to Preview February 1, 2022 01:01 Inactive
@codecov
Copy link

codecov bot commented Feb 1, 2022

Codecov Report

Merging #2859 (8a0b194) into main (8fc93a1) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2859      +/-   ##
==========================================
+ Coverage   84.45%   84.47%   +0.01%     
==========================================
  Files         111      111              
  Lines        8802     8811       +9     
==========================================
+ Hits         7434     7443       +9     
  Misses       1101     1101              
  Partials      267      267              
Impacted Files Coverage Δ
internal/pipe/metadata/metadata.go 90.00% <100.00%> (+1.53%) ⬆️
internal/tmpl/tmpl.go 97.63% <100.00%> (+0.01%) ⬆️
pkg/context/context.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fc93a1...8a0b194. Read the comment docs.

@caarlos0 caarlos0 merged commit 9d481d4 into main Feb 1, 2022
@caarlos0 caarlos0 deleted the runtime branch February 1, 2022 01:36
@github-actions github-actions bot added this to the v1.5.0 milestone Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants