fix: improve deprecate logs #2841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
pull-request-size
bot
added
the
size/S
Codecov Report
@@ Coverage Diff @@
## main #2841 +/- ##
=======================================
Coverage 84.42% 84.43%
=======================================
Files 111 111
Lines 8783 8788 +5
=======================================
+ Hits 7415 7420 +5
Misses 1101 1101
Partials 267 267
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this should prevent concurrent logs from getting the wrong padding, as we wont be messing with the global logger padding anymore
brain dump: maybe worth copying what we actually use from that log library and tune it so we can avoid these kinds of hacks?