Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: artifacts.json should be 0644 instead of 0600 #2801

Merged
merged 2 commits into from Dec 31, 2021
Merged

fix: artifacts.json should be 0644 instead of 0600 #2801

merged 2 commits into from Dec 31, 2021

Conversation

caarlos0
Copy link
Member

closes #2800

@caarlos0
fix: artifacts.json should be 0644 instead of 0600
6d40c55 
Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 31, 2021
@caarlos0
chore: fmt
1c4ff28 
Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
@pull-request-size pull-request-size bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 31, 2021
@vercel vercel bot temporarily deployed to Preview December 31, 2021 17:10 Inactive
@codecov
Copy link

codecov bot commented Dec 31, 2021 •
edited

Codecov Report

Merging #2801 (1c4ff28) into main (e2c3127) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2801   +/-   ##
=======================================
  Coverage   84.94%   84.94%           
=======================================
  Files         106      106           
  Lines        8237     8237           
=======================================
  Hits         6997     6997           
  Misses       1010     1010           
  Partials      230      230
Impacted Files Coverage Δ
internal/pipe/artifacts/artifacts.go 70.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2c3127...1c4ff28. Read the comment docs.

@caarlos0 caarlos0 merged commit bbd79a1 into main Dec 31, 2021
@caarlos0 caarlos0 deleted the artifactsjson-perms branch December 31, 2021 18:05
@github-actions github-actions bot added this to the v1.3.0 milestone Dec 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.3.0
Development

Successfully merging this pull request may close these issues.

artifacts.json has user read/write permission only
1 participant
@caarlos0