fix: sbom binary filter #2798
Merged
fix: sbom binary filter #2798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/XS
Signed-off-by: Carlos Panato <ctadeu@gmail.com>
|
Good catch! Thanks! |
|
cc @caarlos0 |
caarlos0
added a commit
that referenced
this pull request
Dec 30, 2021
refs #2798 Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the
sbomconfig withbinaryartifact it was generating a duplicate list of binaries to generate the sbom and that generate theartifacts.jsonwith duplicate entries and that will fail in the release step when trying to upload the files to the GitHub, for example, it tries to push duplicate files and that fail in the GitHub side.applying this change the list is correct.