fix: logext STDERR use warn instead of error #2791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
pull-request-size
bot
added
the
size/XS
Codecov Report
@@ Coverage Diff @@
## main #2791 +/- ##
=======================================
Coverage 84.95% 84.95%
=======================================
Files 106 106
Lines 8241 8241
=======================================
Hits 7001 7001
Misses 1010 1010
Partials 230 230
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
its common for CLIs to log to STDERR, showing those as errors seems a bit too much, changing them to warn for now. We can then evaluate and maybe change all to info if needed