Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clean user information from remote url if it contains username and token #2457

Merged
merged 1 commit into from Sep 3, 2021
Merged

Conversation

developer-guy
Copy link
Member

Signed-off-by: Batuhan Apaydın batuhan.apaydin@trendyol.com

Fix #2456

to avid showing user information in the message template if someone uses the {{ .GitURL }} within these templates.

@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 3, 2021
@vercel
Copy link

vercel bot commented Sep 3, 2021

@developer-guy is attempting to deploy a commit to the goreleaser Team on Vercel.

A member of the Team first needs to authorize it.

@developer-guy
Copy link
Member Author

cc: @Dentrax @caarlos0

@codecov
Copy link

codecov bot commented Sep 3, 2021

Codecov Report

Merging #2457 (4a1d4d4) into master (1e40bba) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2457      +/-   ##
==========================================
+ Coverage   82.99%   83.01%   +0.01%     
==========================================
  Files          87       87              
  Lines        6264     6271       +7     
==========================================
+ Hits         5199     5206       +7     
  Misses        915      915              
  Partials      150      150              
Impacted Files Coverage Δ
internal/pipe/git/git.go 87.07% <100.00%> (+0.64%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e40bba...4a1d4d4. Read the comment docs.

@pull-request-size pull-request-size bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 3, 2021
@pull-request-size pull-request-size bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 3, 2021
…nd token

Signed-off-by: Batuhan Apaydın <batuhan.apaydin@trendyol.com>
@developer-guy developer-guy reopened this Sep 3, 2021
@pull-request-size pull-request-size bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 3, 2021
@caarlos0 caarlos0 merged commit 5a01a10 into goreleaser:master Sep 3, 2021
@caarlos0
Copy link
Member

caarlos0 commented Sep 3, 2021

Thanks! 🙏

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: username and the ci token variables are shown in the message with the announce integration in Gitlab
2 participants