Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: templateable nfpm key files #2448

Merged
merged 2 commits into from Sep 1, 2021
Merged

feat: templateable nfpm key files #2448

merged 2 commits into from Sep 1, 2021

Conversation

caarlos0
Copy link
Member

@caarlos0 caarlos0 commented Sep 1, 2021

closes #2419

closes #2419

Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
@caarlos0 caarlos0 added the enhancement New feature or request label Sep 1, 2021
@caarlos0 caarlos0 requested a review from a team September 1, 2021 02:58
@caarlos0 caarlos0 self-assigned this Sep 1, 2021
@caarlos0 caarlos0 added this to In progress in Board via automation Sep 1, 2021
@vercel
Copy link

vercel bot commented Sep 1, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/goreleaser/goreleaser/4D3bLa5zsUGUtQvruRSuxrKDKemT
✅ Preview: https://goreleaser-git-nfpm-keys-goreleaser.vercel.app

@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 1, 2021
@codecov
Copy link

codecov bot commented Sep 1, 2021

Codecov Report

Merging #2448 (2d5565e) into master (e2b5e58) will increase coverage by 0.03%.
The diff coverage is 100.00%.

❗ Current head 2d5565e differs from pull request most recent head 2637c8d. Consider uploading reports for the commit 2637c8d to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2448      +/-   ##
==========================================
+ Coverage   83.05%   83.08%   +0.03%     
==========================================
  Files          86       86              
  Lines        6197     6209      +12     
==========================================
+ Hits         5147     5159      +12     
  Misses        900      900              
  Partials      150      150              
Impacted Files Coverage Δ
internal/pipe/nfpm/nfpm.go 94.56% <100.00%> (+0.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2b5e58...2637c8d. Read the comment docs.

@caarlos0 caarlos0 enabled auto-merge (squash) September 1, 2021 04:13
Copy link
Member

@mgrachev mgrachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Board automation moved this from In progress to Reviewer approved Sep 1, 2021
@vercel vercel bot temporarily deployed to Preview September 1, 2021 13:20 Inactive
@caarlos0 caarlos0 merged commit b63e544 into master Sep 1, 2021
Board automation moved this from Reviewer approved to Done Sep 1, 2021
@caarlos0 caarlos0 deleted the nfpm-keys branch September 1, 2021 13:27
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
No open projects
Board
Done
Development

Successfully merging this pull request may close these issues.

Templateable NFPMs signatures
2 participants