Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support links inside archives #2436

Merged
merged 2 commits into from Sep 1, 2021
Merged

feat: support links inside archives #2436

merged 2 commits into from Sep 1, 2021

Conversation

caarlos0
Copy link
Member

closes #2430

support symlinks inside tar.gz, tar.xz and zip files.

probably not perfect, but good enough for now.

Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
@caarlos0 caarlos0 added the enhancement New feature or request label Aug 28, 2021
@caarlos0 caarlos0 self-assigned this Aug 28, 2021
@caarlos0 caarlos0 added this to In progress in Board via automation Aug 28, 2021
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 28, 2021
@vercel
Copy link

vercel bot commented Aug 28, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/goreleaser/goreleaser/Frf7sB75DWEKUEu4zmRW5xk5rW8K
✅ Preview: https://goreleaser-git-links-archives-goreleaser.vercel.app

@codecov
Copy link

codecov bot commented Aug 28, 2021

Codecov Report

Merging #2436 (2613db7) into master (b132d00) will decrease coverage by 0.06%.
The diff coverage is 62.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2436      +/-   ##
==========================================
- Coverage   82.96%   82.89%   -0.07%     
==========================================
  Files          85       85              
  Lines        6215     6227      +12     
==========================================
+ Hits         5156     5162       +6     
- Misses        906      910       +4     
- Partials      153      155       +2     
Impacted Files Coverage Δ
pkg/archive/targz/targz.go 73.21% <57.14%> (-2.79%) ⬇️
pkg/archive/tarxz/tarxz.go 72.72% <62.50%> (-2.79%) ⬇️
pkg/archive/zip/zip.go 78.04% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b132d00...2613db7. Read the comment docs.

@vercel vercel bot temporarily deployed to Preview September 1, 2021 01:43 Inactive
@caarlos0 caarlos0 merged commit 275e17b into master Sep 1, 2021
Board automation moved this from In progress to Done Sep 1, 2021
@caarlos0 caarlos0 deleted the links-archives branch September 1, 2021 02:08
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
No open projects
Board
Done
Development

Successfully merging this pull request may close these issues.

[Bug]: archives not support Regular file
1 participant