Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: announce: reddit #2431

Merged
merged 4 commits into from Aug 31, 2021
Merged

feat: announce: reddit #2431

merged 4 commits into from Aug 31, 2021

Conversation

developer-guy
Copy link
Member

@developer-guy developer-guy commented Aug 26, 2021

@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 26, 2021
@vercel
Copy link

vercel bot commented Aug 26, 2021

@developer-guy is attempting to deploy a commit to the goreleaser Team on Vercel.

A member of the Team first needs to authorize it.

go.mod Outdated Show resolved Hide resolved
Copy link
Member

@caarlos0 caarlos0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the PR!

made a couple of comments :)

can you also add the docs?

also probably worth running go mod tidy and gofumpt -w -s -l . :)

Cheers!

@developer-guy
Copy link
Member Author

thanks for the PR!

made a couple of comments :)

can you also add the docs?

also probably worth running go mod tidy and gofumpt -w -s -l . :)

Cheers!

all done @caarlos0, thank you 🙏

Signed-off-by: Batuhan Apaydın <batuhan.apaydin@trendyol.com>
Copy link
Member

@caarlos0 caarlos0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment, lgtm other than that!

many thanks for the pr 🚀

.goreleaser.yml Outdated Show resolved Hide resolved
@caarlos0 caarlos0 added the enhancement New feature or request label Aug 27, 2021
@caarlos0 caarlos0 added this to In progress in Board via automation Aug 27, 2021
@codecov
Copy link

codecov bot commented Aug 27, 2021

Codecov Report

Merging #2431 (27bc419) into master (70057e8) will decrease coverage by 0.06%.
The diff coverage is 73.91%.

❗ Current head 27bc419 differs from pull request most recent head fa303f1. Consider uploading reports for the commit fa303f1 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2431      +/-   ##
==========================================
- Coverage   83.01%   82.94%   -0.07%     
==========================================
  Files          84       85       +1     
  Lines        6165     6211      +46     
==========================================
+ Hits         5118     5152      +34     
- Misses        894      906      +12     
  Partials      153      153              
Impacted Files Coverage Δ
internal/pipe/announce/announce.go 75.00% <ø> (ø)
pkg/config/config.go 90.72% <ø> (ø)
internal/pipe/reddit/reddit.go 73.91% <73.91%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70057e8...fa303f1. Read the comment docs.

@caarlos0
Copy link
Member

https://www.reddit.com/r/test/comments/pbtik1/goreleaser_v1123_was_just_released_get_it_while/

seems like the link was added to the title? 🤔

@developer-guy
Copy link
Member Author

https://www.reddit.com/r/test/comments/pbtik1/goreleaser_v1123_was_just_released_get_it_while/

seems like the link was added to the title? 🤔

This is from our first test before your reviews; we have just wanted to see the working result 👌 @caarlos0

pkg/defaults/defaults.go Outdated Show resolved Hide resolved
Board automation moved this from In progress to Reviewer approved Aug 31, 2021
@caarlos0 caarlos0 merged commit d3db692 into goreleaser:master Aug 31, 2021
Board automation moved this from Reviewer approved to Done Aug 31, 2021
@caarlos0
Copy link
Member

Thanks!

@developer-guy
Copy link
Member Author

Thanks for merging @caarlos0 ❤️

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
No open projects
Board
Done
Development

Successfully merging this pull request may close these issues.

add Reddit as a new GoReleaser Announce
2 participants