New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: announce: reddit #2431
feat: announce: reddit #2431
Conversation
@developer-guy is attempting to deploy a commit to the goreleaser Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the PR!
made a couple of comments :)
can you also add the docs?
also probably worth running go mod tidy
and gofumpt -w -s -l .
:)
Cheers!
all done @caarlos0, thank you 🙏 |
Signed-off-by: Batuhan Apaydın <batuhan.apaydin@trendyol.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one comment, lgtm other than that!
many thanks for the pr 🚀
Codecov Report
@@ Coverage Diff @@
## master #2431 +/- ##
==========================================
- Coverage 83.01% 82.94% -0.07%
==========================================
Files 84 85 +1
Lines 6165 6211 +46
==========================================
+ Hits 5118 5152 +34
- Misses 894 906 +12
Partials 153 153
Continue to review full report at Codecov.
|
seems like the link was added to the title? 🤔 |
This is from our first test before your reviews; we have just wanted to see the working result 👌 @caarlos0 |
Thanks! |
Thanks for merging @caarlos0 ❤️ |
Signed-off-by: Batuhan Apaydın batuhan.apaydin@trendyol.com
add Reddit support to the Announces, and fix #2424
to add Reddit support
https://www.reddit.com/r/test/comments/pbtik1/goreleaser_v1123_was_just_released_get_it_while/
https://github.com/developer-guy/goreleaser/runs/3429508179?check_suite_focus=true