New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: announce: slack #2429
feat: announce: slack #2429
Conversation
@Dentrax is attempting to deploy a commit to the goreleaser Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, can you add the docs as well?
91746ae
to
a674b2a
Compare
Oh, sure! I updated the type Config struct {
Webhook string `env:"SLACK_WEBHOOK,notEmpty"`
Channel string `env:"SLACK_CHANNEL,notEmpty"`
Username string `env:"SLACK_USERNAME"`
IconEmoji string `env:"SLACK_ICON_EMOJI"`
IconURL string `env:"SLACK_ICON_URL"`
} But I think we can pass only i.e. announce:
slack:
enabled: true
message_template: 'Awesome project {{.Tag}} is out!'
channel: foo
username: MyAwesomeApp
icon_emoji: :my-awesome-emoji: |
a674b2a
to
ebf974e
Compare
I think so, yes. We can keep on env only the "secrets". |
Codecov Report
@@ Coverage Diff @@
## master #2429 +/- ##
==========================================
- Coverage 83.10% 82.88% -0.23%
==========================================
Files 86 85 -1
Lines 6214 6204 -10
==========================================
- Hits 5164 5142 -22
- Misses 900 909 +9
- Partials 150 153 +3
Continue to review full report at Codecov.
|
ebf974e
to
41a9719
Compare
Updated. ✌️ |
41a9719
to
398b884
Compare
there are some conflicts, can you merge with master? other than that, lgtm 🙏 |
Fixes goreleaser#2425 Signed-off-by: Furkan <furkan.turkal@trendyol.com>
398b884
to
fd4940d
Compare
I think I fixed the conflicts. Can you please review again? 🤗 We tested this new announce on our upcoming private project kink (kind in kubernetes), it will out soon. |
Name string `yaml:",omitempty"` | ||
Tap RepoRef `yaml:",omitempty"` | ||
CommitAuthor CommitAuthor `yaml:"commit_author,omitempty"` | ||
CommitMessageTemplate string `yaml:"commit_msg_template,omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this field needs to stay
@@ -2,7 +2,7 @@ | |||
title: Announce | |||
--- | |||
|
|||
GoReleaser can also announce new releases, currently, to Twitter only. | |||
GoReleaser can also announce new releases, currently, to Twitter and Slack only. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GoReleaser can also announce new releases, currently, to Twitter and Slack only. | |
GoReleaser can also announce new releases, currently, to Twitter, Reddit and Slack only. |
Will merge and fix the conflict manually |
thanks again for the hard work on this 💛 |
This PR adds support for Slack Announce!
Fixes #2425
Signed-off-by: Furkan furkan.turkal@trendyol.com