Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upload gcs blobs to bucket root #2409

Merged
merged 2 commits into from Aug 17, 2021
Merged

Conversation

caarlos0
Copy link
Member

@caarlos0 caarlos0 commented Aug 17, 2021

add tests to #2373

closes #2373

abemedia and others added 2 commits July 30, 2021 19:31
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
@vercel
Copy link

vercel bot commented Aug 17, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/goreleaser/goreleaser/6v79BqHNRoc5PXRRNXW7JSJEuN6Z
✅ Preview: https://goreleaser-git-fix-gcs-root-blob-upload-goreleaser.vercel.app

@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 17, 2021
@codecov
Copy link

codecov bot commented Aug 17, 2021

Codecov Report

Merging #2409 (f2b6db2) into master (5b3f286) will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2409      +/-   ##
==========================================
+ Coverage   82.92%   82.99%   +0.07%     
==========================================
  Files          83       83              
  Lines        6062     6088      +26     
==========================================
+ Hits         5027     5053      +26     
+ Misses        887      886       -1     
- Partials      148      149       +1     
Impacted Files Coverage Δ
internal/pipe/blob/upload.go 73.80% <100.00%> (+0.31%) ⬆️
internal/pipe/docker/manifest.go 96.66% <0.00%> (-3.34%) ⬇️
internal/pipe/docker/docker.go 89.18% <0.00%> (-1.53%) ⬇️
internal/pipe/scoop/scoop.go 78.65% <0.00%> (-0.39%) ⬇️
pkg/config/config.go 90.72% <0.00%> (ø)
internal/builders/golang/build.go 92.89% <0.00%> (+0.20%) ⬆️
internal/exec/exec.go 85.60% <0.00%> (+0.23%) ⬆️
internal/pipe/gomod/gomod.go 78.44% <0.00%> (+0.37%) ⬆️
internal/builders/golang/targets.go 100.00% <0.00%> (+6.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b3f286...f2b6db2. Read the comment docs.

@caarlos0 caarlos0 merged commit 3966921 into master Aug 17, 2021
@caarlos0 caarlos0 deleted the fix/gcs-root-blob-upload branch August 17, 2021 03:31
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants