Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add id to dockers and docker_manifests #2399

Merged
merged 3 commits into from Aug 17, 2021
Merged

feat: add id to dockers and docker_manifests #2399

merged 3 commits into from Aug 17, 2021

Conversation

caarlos0
Copy link
Member

closes #2398

@caarlos0
feat: add id to dockers and docker_manifests
6014840 
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
@caarlos0 caarlos0 added the enhancement New feature or request label Aug 13, 2021
@caarlos0 caarlos0 self-assigned this Aug 13, 2021
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 13, 2021
@vercel
Copy link

vercel bot commented Aug 13, 2021 •
edited

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/goreleaser/goreleaser/DtpiTiuceFMDE1DDaAvEP7LaYAco
✅ Preview: https://goreleaser-git-docker-img-ids-goreleaser.vercel.app

@caarlos0 caarlos0 mentioned this pull request Aug 13, 2021
Closed
@codecov
Copy link

codecov bot commented Aug 13, 2021 •
edited

Codecov Report

Merging #2399 (d44aec8) into master (72b7f3b) will decrease coverage by 0.04%.
The diff coverage is 79.31%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2399      +/-   ##
==========================================
- Coverage   82.92%   82.87%   -0.05%     
==========================================
  Files          83       83              
  Lines        6060     6080      +20     
==========================================
+ Hits         5025     5039      +14     
- Misses        887      891       +4     
- Partials      148      150       +2
Impacted Files Coverage Δ
pkg/config/config.go 90.72% <ø> (ø)
internal/pipe/docker/docker.go 89.18% <75.00%> (-1.16%) ⬇️
internal/pipe/docker/manifest.go 96.66% <80.00%> (-3.34%) ⬇️
internal/exec/exec.go 85.60% <100.00%> (+0.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72b7f3b...d44aec8. Read the comment docs.

ryancurrah
ryancurrah approved these changes Aug 16, 2021
View reviewed changes
Copy link
Contributor

@ryancurrah ryancurrah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Seems fairly simple.

internal/pipe/docker/docker.go
Extra: map[string]interface{}{},
}
if docker.ID != "" {
art.Extra["ID"] = docker.ID
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity why do this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the field used by the ids filters later...

@caarlos0
Merge remote-tracking branch 'origin/master' into docker-img-ids
15cef4d 
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
@caarlos0
feat: actually allow to use the images
d44aec8 
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
@pull-request-size pull-request-size bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 16, 2021
@vercel vercel bot temporarily deployed to Preview August 16, 2021 18:30 Inactive
@caarlos0 caarlos0 merged commit d329a9c into master Aug 17, 2021
@caarlos0 caarlos0 deleted the docker-img-ids branch August 17, 2021 01:11
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ryancurrah ryancurrah ryancurrah approved these changes

Assignees

@caarlos0 caarlos0

Labels
enhancement New feature or request size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add the id property to docker images and manifests
2 participants
@caarlos0 @ryancurrah