fix: main check when using gomod.proxy #2390
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we can't check for the
main
function in the actual proxied module, but we can at least check the code which, in theory, is the module being proxied.this should avoid bad releases as I did for fork-cleaner, which was basically empty.
What happens now is that the
gomod
pipe overridesMain
andDir
as before, but set the original values toUnproxiedMain
andUnproxiedDir
, and then thebuild
pipe checks the main on the unproxied properties when they exist.