Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make scoop write .json when --skip-publish #2380

Conversation

jonaslu
Copy link
Contributor

@jonaslu jonaslu commented Aug 3, 2021

Don't skip the pipeline altogether but write
out the manifest.json file as the homebrew
pipeline does, only skip committing to the repo.

closes #2374

@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 3, 2021
@vercel
Copy link

vercel bot commented Aug 3, 2021

@jonaslu is attempting to deploy a commit to the goreleaser Team on Vercel.

A member of the Team first needs to authorize it.

Don't skip the pipeline altogether but write
out the manifest.json file as the homebrew
pipeline does, only skip committing to the repo.

closes goreleaser#2374
@jonaslu jonaslu force-pushed the bugfix/scoop-write-manifest-when-skip-publish branch from e16c135 to b8c9d6c Compare August 3, 2021 01:49
@caarlos0
Copy link
Member

caarlos0 commented Aug 3, 2021

thanks for the PR :)

@caarlos0 caarlos0 enabled auto-merge (squash) August 3, 2021 02:32
@codecov
Copy link

codecov bot commented Aug 3, 2021

Codecov Report

Merging #2380 (b8c9d6c) into master (18695c2) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head b8c9d6c differs from pull request most recent head a8182f6. Consider uploading reports for the commit a8182f6 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2380      +/-   ##
==========================================
- Coverage   82.92%   82.91%   -0.01%     
==========================================
  Files          83       83              
  Lines        6062     6059       -3     
==========================================
- Hits         5027     5024       -3     
  Misses        887      887              
  Partials      148      148              
Impacted Files Coverage Δ
internal/pipe/scoop/scoop.go 78.65% <ø> (-0.39%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18695c2...a8182f6. Read the comment docs.

@caarlos0 caarlos0 merged commit 7f0edf6 into goreleaser:master Aug 3, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2021

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Scoop pipeline does not write out .json file with --skip-publish
2 participants