Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nfpm): wire up two additional nfpm properties #1995

Merged
merged 1 commit into from
Jan 6, 2021
Merged

feat(nfpm): wire up two additional nfpm properties #1995

merged 1 commit into from
Jan 6, 2021

Conversation

ryancurrah
Copy link
Contributor

The properties Section and Priority are currently omitted from the goreleaser config. This commit wires them up so we can use them to build our packages.

Provides two new properties to provide to NFPM, Section and Priority.

Allows us to add these properties to our Debian packages.

https://github.com/goreleaser/nfpm/blob/master/nfpm.go#L168-L169

The properties Section and Priority are currently ommited from the goreleaser config. This commit wires them up so we can use them to build our packages.
@vercel
Copy link

vercel bot commented Jan 5, 2021

@ryancurrah is attempting to deploy a commit to the Goreleaser Team on Vercel.

A member of the Team first needs to authorize it.

@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 5, 2021
@codecov
Copy link

codecov bot commented Jan 5, 2021

Codecov Report

Merging #1995 (fc10a9d) into master (a9c143c) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1995   +/-   ##
=======================================
  Coverage   82.83%   82.83%           
=======================================
  Files          74       74           
  Lines        3980     3980           
=======================================
  Hits         3297     3297           
  Misses        556      556           
  Partials      127      127           
Impacted Files Coverage Δ
pkg/config/config.go 93.75% <ø> (ø)
internal/pipe/nfpm/nfpm.go 95.34% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9c143c...fc10a9d. Read the comment docs.

@kodiakhq kodiakhq bot merged commit ac0cc32 into goreleaser:master Jan 6, 2021
@caarlos0
Copy link
Member

caarlos0 commented Jan 6, 2021

Thanks 🙏

@ryancurrah
Copy link
Contributor Author

I was going to add these to the docs but I was not sure where to do that.

@caarlos0
Copy link
Member

caarlos0 commented Jan 6, 2021

I was going to add these to the docs but I was not sure where to do that.

already did in df10503

@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2021

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants