Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use git tag --points-at to detect the legitimate tag #1793

Closed
crazy-max opened this issue Sep 6, 2020 · 1 comment · Fixed by #1796
Closed

Use git tag --points-at to detect the legitimate tag #1793

crazy-max opened this issue Sep 6, 2020 · 1 comment · Fixed by #1796
Labels
enhancement New feature or request

Comments

@crazy-max
Copy link
Member

@caarlos0

Refs. goreleaser/goreleaser-action#238 goreleaser/goreleaser-action#239

As explained on Slack, I think git describe is (maybe) not a good way to detect the "proper" tag. We should first use git tag --points-at to detect the legitimate latest tag if a commit has multi tags (sort by -version:creatordate). If none is found/valid then we can use git describe --tags --abbrev=0.

You can find an implementation in our GitHub Action.
@crazy-max crazy-max added the enhancement New feature or request label Sep 6, 2020
@caarlos0 caarlos0 mentioned this issue Sep 7, 2020
Merged
@github-actions
Copy link
Contributor

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: use git tag --points-at goreleaser/goreleaser
1 participant
@crazy-max