fix: don't depend on the GitHub API to check release #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crazy-max
commented
Jan 29, 2023
| "@actions/http-client": "^2.0.1", | ||
| "@actions/tool-cache": "^2.0.1", | ||
| "js-yaml": "^4.1.0", | ||
| "semver": "^7.3.8", |
There was a problem hiding this comment.
Also found that semver module was not properly registered.
crazy-max
commented
Jan 29, 2023
| @@ -23,10 +23,10 @@ | |||
| "dependencies": { | |||
| "@actions/core": "^1.10.0", | |||
| "@actions/exec": "^1.1.1", | |||
| "@actions/github": "^5.1.1", | |||
There was a problem hiding this comment.
This module is not necessary anymore
Codecov Report
@@ Coverage Diff @@
## master #391 +/- ##
==========================================
+ Coverage 64.95% 67.18% +2.23%
==========================================
Files 3 3
Lines 117 128 +11
Branches 18 22 +4
==========================================
+ Hits 76 86 +10
+ Misses 28 27 -1
- Partials 13 15 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
caarlos0
approved these changes
Jan 30, 2023
|
@caarlos0 I don't think it's necessary. Introducing |
ah, right lgtm then :D |
|
Oh sorry I misunderstood, I thought you were saying a new major (v5) so yeah we shoud do a release |
|
|
I was, but misstyped 😂 all good, your argument makes 100% sense and this seems like the way to go! |
renovate bot
added a commit
to DelineaXPM/terraform-provider-dsv
that referenced
this pull request
Jan 23, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [actions/checkout](https://togithub.com/actions/checkout) | action | major | `v3` -> `v4` | | [crazy-max/ghaction-import-gpg](https://togithub.com/crazy-max/ghaction-import-gpg) | action | major | `v5` -> `v6` | | [goreleaser/goreleaser-action](https://togithub.com/goreleaser/goreleaser-action) | action | major | `v3.2.0` -> `v5.0.0` | | [magefile/mage-action](https://togithub.com/magefile/mage-action) | action | major | `v2` -> `v3` | | [magnetikonline/action-golang-cache](https://togithub.com/magnetikonline/action-golang-cache) | action | major | `v3` -> `v4` | --- ### Release Notes <details> <summary>actions/checkout (actions/checkout)</summary> ### [`v4`](https://togithub.com/actions/checkout/blob/HEAD/CHANGELOG.md#v400) [Compare Source](https://togithub.com/actions/checkout/compare/v3...v4) - [Support fetching without the --progress option](https://togithub.com/actions/checkout/pull/1067) - [Update to node20](https://togithub.com/actions/checkout/pull/1436) </details> <details> <summary>crazy-max/ghaction-import-gpg (crazy-max/ghaction-import-gpg)</summary> ### [`v6`](https://togithub.com/crazy-max/ghaction-import-gpg/compare/v5...v6) [Compare Source](https://togithub.com/crazy-max/ghaction-import-gpg/compare/v5...v6) </details> <details> <summary>goreleaser/goreleaser-action (goreleaser/goreleaser-action)</summary> ### [`v5.0.0`](https://togithub.com/goreleaser/goreleaser-action/releases/tag/v5.0.0) [Compare Source](https://togithub.com/goreleaser/goreleaser-action/compare/v4.6.0...v5.0.0) #### What's Changed - feat: node 20 as default runtime (requires [Actions Runner v2.308.0](https://togithub.com/actions/runner/releases/tag/v2.308.0) or later) by [@​crazy-max](https://togithub.com/crazy-max) in [goreleaser/goreleaser-action#432 - chore(deps): bump [@​actions/core](https://togithub.com/actions/core) from 1.10.0 to 1.10.1 in [goreleaser/goreleaser-action#434 **Full Changelog**: goreleaser/goreleaser-action@v4.6.0...v5.0.0 ### [`v4.6.0`](https://togithub.com/goreleaser/goreleaser-action/releases/tag/v4.6.0) [Compare Source](https://togithub.com/goreleaser/goreleaser-action/compare/v4.5.0...v4.6.0) Reverts the change to `node20` runtime. **Full Changelog**: goreleaser/goreleaser-action@v4.5.0...v4.6.0 ### [`v4.5.0`](https://togithub.com/goreleaser/goreleaser-action/releases/tag/v4.5.0) [Compare Source](https://togithub.com/goreleaser/goreleaser-action/compare/v4.4.0...v4.5.0) #### What's Changed - chore(deps): bump word-wrap from 1.2.3 to 1.2.5 by [@​dependabot](https://togithub.com/dependabot) in [goreleaser/goreleaser-action#427 - feat: bump to use node20 runtime, actions/checkout to v4 by [@​kbdharun](https://togithub.com/kbdharun) in [goreleaser/goreleaser-action#430 #### New Contributors - [@​kbdharun](https://togithub.com/kbdharun) made their first contribution in [goreleaser/goreleaser-action#430 **Full Changelog**: goreleaser/goreleaser-action@v4.4.0...v4.5.0 ### [`v4.4.0`](https://togithub.com/goreleaser/goreleaser-action/releases/tag/v4.4.0) [Compare Source](https://togithub.com/goreleaser/goreleaser-action/compare/v4.3.0...v4.4.0) #### What's Changed - chore(deps): bump semver from 7.5.0 to 7.5.1 by [@​dependabot](https://togithub.com/dependabot) in [goreleaser/goreleaser-action#417 - feat: support oss nightlies by [@​caarlos0](https://togithub.com/caarlos0) in [goreleaser/goreleaser-action#424 **Full Changelog**: goreleaser/goreleaser-action@v4.3.0...v4.4.0 ### [`v4.3.0`](https://togithub.com/goreleaser/goreleaser-action/releases/tag/v4.3.0) [Compare Source](https://togithub.com/goreleaser/goreleaser-action/compare/v4.2.0...v4.3.0) #### What's Changed - Update in command examples by [@​arnaduga](https://togithub.com/arnaduga) in [goreleaser/goreleaser-action#393 - chore(deps): bump yargs from 17.6.2 to 17.7.0 by [@​dependabot](https://togithub.com/dependabot) in [goreleaser/goreleaser-action#395 - Improve documentation for use of `GITHUB_TOKEN` by [@​jamietanna](https://togithub.com/jamietanna) in [goreleaser/goreleaser-action#399 - chore(deps): bump actions/setup-go from 3 to 4 by [@​dependabot](https://togithub.com/dependabot) in [goreleaser/goreleaser-action#403 - chore(deps): bump docker/bake-action from 2 to 3 by [@​dependabot](https://togithub.com/dependabot) in [goreleaser/goreleaser-action#408 - chore(deps): bump semver from 7.3.8 to 7.5.0 by [@​dependabot](https://togithub.com/dependabot) in [goreleaser/goreleaser-action#407 - Bump setup-go action version to v4 in README by [@​kishaningithub](https://togithub.com/kishaningithub) in [goreleaser/goreleaser-action#411 - ci: split test and validate workflow by [@​crazy-max](https://togithub.com/crazy-max) in [goreleaser/goreleaser-action#413 - chore: update yarn to 3.5.1 by [@​crazy-max](https://togithub.com/crazy-max) in [goreleaser/goreleaser-action#412 - chore(deps): bump yargs from 17.7.1 to 17.7.2 by [@​dependabot](https://togithub.com/dependabot) in [goreleaser/goreleaser-action#410 - feat: support nightly by [@​caarlos0](https://togithub.com/caarlos0) in [goreleaser/goreleaser-action#419 #### New Contributors - [@​arnaduga](https://togithub.com/arnaduga) made their first contribution in [goreleaser/goreleaser-action#393 - [@​jamietanna](https://togithub.com/jamietanna) made their first contribution in [goreleaser/goreleaser-action#399 - [@​kishaningithub](https://togithub.com/kishaningithub) made their first contribution in [goreleaser/goreleaser-action#411 **Full Changelog**: goreleaser/goreleaser-action@v4.2.0...v4.3.0 ### [`v4.2.0`](https://togithub.com/goreleaser/goreleaser-action/releases/tag/v4.2.0) [Compare Source](https://togithub.com/goreleaser/goreleaser-action/compare/v4.1.1...v4.2.0) ##### What's Changed - fix: don't depend on the GitHub API to check release by [@​crazy-max](https://togithub.com/crazy-max) in [goreleaser/goreleaser-action#391 **Full Changelog**: goreleaser/goreleaser-action@v4.1.1...v4.2.0 ### [`v4.1.1`](https://togithub.com/goreleaser/goreleaser-action/releases/tag/v4.1.1) [Compare Source](https://togithub.com/goreleaser/goreleaser-action/compare/v4.1.0...v4.1.1) ##### What's Changed - Update Readme to reference `goreleaser/goreleaser-action@v4` by [@​felladrin](https://togithub.com/felladrin) in [goreleaser/goreleaser-action#384 - docs: fix README badge by [@​dirien](https://togithub.com/dirien) in [goreleaser/goreleaser-action#386 - chore(deps): bump json5 from 2.2.0 to 2.2.3 by [@​dependabot](https://togithub.com/dependabot) in [goreleaser/goreleaser-action#388 - fix: use [@​action/github](https://togithub.com/action/github) by [@​caarlos0](https://togithub.com/caarlos0) and [@​crazy-max](https://togithub.com/crazy-max) in [goreleaser/goreleaser-action#390 ##### New Contributors - [@​felladrin](https://togithub.com/felladrin) made their first contribution in [goreleaser/goreleaser-action#384 - [@​dirien](https://togithub.com/dirien) made their first contribution in [goreleaser/goreleaser-action#386 **Full Changelog**: goreleaser/goreleaser-action@v4.1.0...v4.1.1 ### [`v4.1.0`](https://togithub.com/goreleaser/goreleaser-action/releases/tag/v4.1.0) [Compare Source](https://togithub.com/goreleaser/goreleaser-action/compare/v4.0.0...v4.1.0) ##### What's Changed - feat!: remove auto-snapshot on dirty tag by [@​caarlos0](https://togithub.com/caarlos0) in [goreleaser/goreleaser-action#382 - docs: add example when using workdir along with upload-artifact by [@​zdtsw](https://togithub.com/zdtsw) in [goreleaser/goreleaser-action#366 - Fix Self-Hosted Windows Error: Expand-Archive by [@​flarco](https://togithub.com/flarco) in [goreleaser/goreleaser-action#379 - chore(deps): bump minimatch from 3.0.4 to 3.1.2 by [@​dependabot](https://togithub.com/dependabot) in [goreleaser/goreleaser-action#383 ##### Migrating from v3 If you need the auto-snapshot feature, take a look at [this example repository](https://togithub.com/caarlos0/goreleaser-action-v4-auto-snapshot-example): it's a minimal working example with all you need. ##### New Contributors - [@​zdtsw](https://togithub.com/zdtsw) made their first contribution in [goreleaser/goreleaser-action#366 - [@​flarco](https://togithub.com/flarco) made their first contribution in [goreleaser/goreleaser-action#379 **Full Changelog**: goreleaser/goreleaser-action@v4...v4.1.0 ### [`v4.0.0`](https://togithub.com/goreleaser/goreleaser-action/releases/tag/v4.0.0) [Compare Source](https://togithub.com/goreleaser/goreleaser-action/compare/v3.2.0...v4.0.0) ##### What's Changed - fix: do not override GORELEASER_CURRENT_TAG by [@​caarlos0](https://togithub.com/caarlos0) in [goreleaser/goreleaser-action#370 ##### Migrating from v3 If you need the auto-snapshot feature, take a look at [this example repository](https://togithub.com/caarlos0/goreleaser-action-v4-auto-snapshot-example): it's a minimal working example with all you need. **Full Changelog**: goreleaser/goreleaser-action@v3...v4.0.0 </details> <details> <summary>magefile/mage-action (magefile/mage-action)</summary> ### [`v3`](https://togithub.com/magefile/mage-action/compare/v2...v3) [Compare Source](https://togithub.com/magefile/mage-action/compare/v2...v3) </details> <details> <summary>magnetikonline/action-golang-cache (magnetikonline/action-golang-cache)</summary> ### [`v4`](https://togithub.com/magnetikonline/action-golang-cache/releases/tag/v4) [Compare Source](https://togithub.com/magnetikonline/action-golang-cache/compare/v3...v4) - Provide action outputs of `build-cache-path`, `module-cache-path` and `cache-key`. - Bump `actions/setup-go@v4` - Some `README.md` cleanups. </details> --- ### Configuration 📅 **Schedule**: Branch creation - "every weekday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/DelineaXPM/terraform-provider-dsv). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMzUuMCIsInVwZGF0ZWRJblZlciI6IjM3LjEzNS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow-up docker/buildx#1563
We are currently using the GitHub API to check for latest and tagged releases to make sure they exist before download. But this requires using a token to avoid rate-limit. It's fine for public runners but GHES runners don't have the
github.tokenpopulated automatically (see docker/setup-buildx-action#194). They need to create a PAT.We actually don't need to use the GitHub API at all as we have the list of releases available: