Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: get darwin universal binary #312

Merged
merged 1 commit into from Oct 15, 2021
Merged

fix: get darwin universal binary #312

merged 1 commit into from Oct 15, 2021

Conversation

caarlos0
Copy link
Member

fixes action to use the new macos universal binaries.

Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
@caarlos0 caarlos0 added the bug Something isn't working label Oct 15, 2021
@caarlos0 caarlos0 self-assigned this Oct 15, 2021
@caarlos0 caarlos0 added this to In progress in Board via automation Oct 15, 2021
@caarlos0 caarlos0 enabled auto-merge (squash) October 15, 2021 12:36
@codecov
Copy link

codecov bot commented Oct 15, 2021

Codecov Report

Merging #312 (0399e93) into master (69b075d) will decrease coverage by 0.58%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #312      +/-   ##
==========================================
- Coverage   80.19%   79.61%   -0.59%     
==========================================
  Files           4        4              
  Lines         101      103       +2     
  Branches       17       18       +1     
==========================================
+ Hits           81       82       +1     
- Misses         12       13       +1     
  Partials        8        8              
Impacted Files Coverage Δ
src/installer.ts 77.77% <50.00%> (-1.30%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69b075d...0399e93. Read the comment docs.

Copy link
Member

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@caarlos0 caarlos0 merged commit 5df302e into master Oct 15, 2021
Board automation moved this from In progress to Reviewer approved Oct 15, 2021
Board automation moved this from Reviewer approved to Done Oct 15, 2021
@caarlos0 caarlos0 deleted the darwin-universal branch October 15, 2021 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size/M
Projects
No open projects
Board
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants