Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: platform detection v2 #300

Merged
merged 1 commit into from Aug 27, 2021
Merged

fix: platform detection v2 #300

merged 1 commit into from Aug 27, 2021

Conversation

crazy-max
Copy link
Member

Fix my stupid mistake πŸ™ƒ

Codespaces is so great I can fix that from the beach on my phone πŸ–οΈ

cc @tenyo

@codecov
Copy link

codecov bot commented Aug 26, 2021

Codecov Report

Merging #300 (988c5ef) into master (f9141d0) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #300   +/-   ##
=======================================
  Coverage   85.86%   85.86%           
=======================================
  Files           4        4           
  Lines          92       92           
  Branches       17       17           
=======================================
  Hits           79       79           
  Misses          6        6           
  Partials        7        7           
Impacted Files Coverage Ξ”
src/installer.ts 94.11% <100.00%> (ΓΈ)

Continue to review full report at Codecov.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update f9141d0...988c5ef. Read the comment docs.

@crazy-max
Copy link
Member Author

@tenyo Can you also add this step and give me the output please?

      - uses: actions/github-script@v4
        with:
          script: |
            const os = require('os')
            console.log(os.platform(), os.arch())

@tenyo
Copy link

tenyo commented Aug 26, 2021

@tenyo Can you also add this step and give me the output please?

      - uses: actions/github-script@v4
        with:
          script: |
            const os = require('os')
            console.log(os.platform(), os.arch())

The output was:
linux arm64

@tenyo
Copy link

tenyo commented Aug 26, 2021

Just tried with uses: goreleaser/goreleaser-action@fix-platform-v2 and it's pulling the correct arm64 version now πŸŽ‰

@crazy-max crazy-max merged commit bc087ef into master Aug 27, 2021
@crazy-max crazy-max deleted the fix-platform-v2 branch August 27, 2021 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants