Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: ci tests pro version #288

Merged
merged 11 commits into from May 30, 2021
Merged

test: ci tests pro version #288

merged 11 commits into from May 30, 2021

Conversation

caarlos0
Copy link
Member

@caarlos0 caarlos0 commented May 30, 2021

test pro version on CI as well

Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
@caarlos0 caarlos0 added the enhancement New feature or request label May 30, 2021
@caarlos0 caarlos0 requested a review from crazy-max May 30, 2021 14:45
@caarlos0 caarlos0 self-assigned this May 30, 2021
@codecov
Copy link

codecov bot commented May 30, 2021

Codecov Report

Merging #288 (9aae1b8) into master (bbb1d19) will not change coverage.
The diff coverage is n/a.

❗ Current head 9aae1b8 differs from pull request most recent head 65574e6. Consider uploading reports for the commit 65574e6 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #288   +/-   ##
=======================================
  Coverage   86.40%   86.40%           
=======================================
  Files           5        5           
  Lines         103      103           
  Branches       18       18           
=======================================
  Hits           89       89           
  Misses          6        6           
  Partials        8        8           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbb1d19...65574e6. Read the comment docs.

Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
Copy link
Member

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Secret will not be available on PR so it will fail for forks unfortunately but we could use the pull_request_target event for that. Wonder if we should skip the "pro" part on PR.

caarlos0 and others added 7 commits May 30, 2021 14:59
Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
@caarlos0 caarlos0 enabled auto-merge (squash) May 30, 2021 15:16
@caarlos0 caarlos0 requested a review from crazy-max May 30, 2021 15:17
@caarlos0 caarlos0 merged commit ac06743 into master May 30, 2021
@caarlos0 caarlos0 deleted the tests branch May 30, 2021 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants