Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GORELEASER_CURRENT_TAG is not respected with v2.4 #260

Closed
spirosoik opened this issue Dec 1, 2020 · 8 comments
Closed

GORELEASER_CURRENT_TAG is not respected with v2.4 #260

spirosoik opened this issue Dec 1, 2020 · 8 comments

Comments

@spirosoik
Copy link

This seems to break the functionality. #259

Reference comment #259 (comment)

@crazy-max
Copy link
Member

@spirosoik I would need some logs please. Thanks.

@spirosoik
Copy link
Author

I will try to see how I can redact a few stuff

@stack72
Copy link

stack72 commented Dec 2, 2020

Hi

I am seeing the same issue. Our builds are public so I can share the links...

You can see the GORELEASER_CURRENT_TAG being set to GITHUB_ENV here - https://github.com/pulumi/pulumi-azure/runs/1475650624?check_suite_focus=true#step:9:2

You can then see that available as an environment variable here - https://github.com/pulumi/pulumi-azure/runs/1475650624?check_suite_focus=true#step:10:32

But you can see that it hasn't respected that value - https://github.com/pulumi/pulumi-azure/runs/1475650624?check_suite_focus=true#step:10:43

@crazy-max
Copy link
Member

@stack72 In your case it looks like you handle GORELEASER_CURRENT_TAG yourself so the action overwrites it. I will push a fix for that. Maybe it will fix the current issue too.

@stack72
Copy link

stack72 commented Dec 2, 2020

This is something we've been doing for months and just stopped working recently so I assumed it was the same thing - maybe not though

Thank you so much for pinging back on this!

@crazy-max
Copy link
Member

@stack72 I've pushed a fix, can you test?

@stack72
Copy link

stack72 commented Dec 2, 2020

@stack72 I've pushed a fix, can you test?

Testing it now - will update you on how it goes! thank you :)

@stack72
Copy link

stack72 commented Dec 2, 2020

@stack72 I've pushed a fix, can you test?

Testing it now - will update you on how it goes! thank you :)

Worked a treat @crazy-max - thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants