Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add install-only option for using goreleaser in user scripts #252

Merged
merged 2 commits into from Nov 6, 2020

Conversation

arunvelsriram
Copy link
Contributor

@arunvelsriram arunvelsriram commented Oct 25, 2020

Closes #250

Added install-only option that installs GoReleaser, add it to PATH and exits. In the subsequent steps users can consume goreleaser CLI.

@codecov
Copy link

codecov bot commented Oct 25, 2020

Codecov Report

Merging #252 (3f5ecc4) into master (7036418) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #252   +/-   ##
=======================================
  Coverage   88.76%   88.76%           
=======================================
  Files           4        4           
  Lines          89       89           
  Branches       16       16           
=======================================
  Hits           79       79           
  Misses          5        5           
  Partials        5        5           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7036418...3f5ecc4. Read the comment docs.

Copy link
Member

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contrib. Some small changes and also please update the README. And update your commit message with a conventional one like feat: Add install-only option for using goreleaser in user scripts. Don"t worry about ci / signing failed tests, it's an issue on our side.

src/main.ts Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
action.yml Outdated Show resolved Hide resolved
@crazy-max crazy-max self-requested a review November 6, 2020 20:20
Copy link
Member

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Install only option
2 participants