Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with symlinks in directories for nfpm #24

Merged
merged 4 commits into from Feb 9, 2022

Conversation

Felixoid
Copy link
Contributor

@Felixoid Felixoid commented Feb 9, 2022

It is the first step necessary to solve goreleaser/nfpm#428

@Felixoid
Copy link
Contributor Author

Felixoid commented Feb 9, 2022

I am sorry, @caarlos0, are checks working even? They haven't started for f338501 in ~8 hours

@caarlos0
Copy link
Member

caarlos0 commented Feb 9, 2022

I am sorry, @caarlos0, are checks working even? They haven't started for f338501 in ~8 hours

it asks for a maintainer to approve, just did

@codecov
Copy link

codecov bot commented Feb 9, 2022

Codecov Report

Merging #24 (cb8d871) into main (80e86ff) will increase coverage by 0.43%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #24      +/-   ##
==========================================
+ Coverage   81.96%   82.40%   +0.43%     
==========================================
  Files           2        2              
  Lines         122      125       +3     
==========================================
+ Hits          100      103       +3     
  Misses         13       13              
  Partials        9        9              
Impacted Files Coverage Δ
glob.go 81.60% <100.00%> (+0.65%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80e86ff...cb8d871. Read the comment docs.

glob_test.go Outdated Show resolved Hide resolved
@Felixoid
Copy link
Contributor Author

Felixoid commented Feb 9, 2022

I don't see what's the issue with linter, actually

upd: I've run it locally, added skip for the assertion check

@Felixoid
Copy link
Contributor Author

Felixoid commented Feb 9, 2022

Does it look good now?

@caarlos0 caarlos0 merged commit 5824e57 into goreleaser:main Feb 9, 2022
@caarlos0
Copy link
Member

caarlos0 commented Feb 9, 2022

thanks!

caarlos0 added a commit that referenced this pull request Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants