Fix flakey watch deletion test for FSEvents #891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samschott
force-pushed
the
flakey-watch-deletion-test
branch
from
9d2950b
to
180fd36
Compare
|
Thanks @samschott 🍾 |
|
That was quick! I hope this actually fixes it, it was the best reason I could find for the failure 🤞 |
|
It cannot be worse, and the new code is still simple to follow, so 👍 :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the occasional failures of
tests/test_fsevents.py::test_watcher_deletion_while_receiving_events_2.The test would fail not because of error messages in the captured log output (what it's aiming to test) but rather due to DEBUG messages in the log output despite the log level being set to ERROR. This is because file system events are logged at DEBUG and may enter the log after exiting the
caplogcontext from the previous run and before entering the context in the next run.This PR fixes this by staying in the
caplogcontext with level ERROR throughout the test.