Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

watchmedo - argparse for --kill-after needs to be a float #870

Closed
cbellinz opened this issue Jan 19, 2022 · 1 comment · Fixed by #886
Closed

watchmedo - argparse for --kill-after needs to be a float #870

cbellinz opened this issue Jan 19, 2022 · 1 comment · Fixed by #886

Comments

@cbellinz
Copy link

If you set --kill-after argument on watchmedo then it will fail as the argparse configuration is not set to a float.

It needs to be:

          argument('--kill-after',
                   dest='kill_after',
                   default=10.0,
                   type=float,
                   help='When stopping, kill the subprocess after the specified timeout '
                   'in seconds (default 10.0).')])
@BoboTiG
Copy link
Collaborator

BoboTiG commented Jan 19, 2022

Good catch!

If anyone wants to give a hand, a potential patch should contain a test case :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants