[macOS] Emit FileModifiedEvent on permission change #815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alongside other metadata modifications
samschott
force-pushed
the
fix-missed-metadata-change
branch
from
8f2ba5c
to
c1e26ae
Compare
samschott
force-pushed
the
fix-missed-metadata-change
branch
from
7bf2bb6
to
2b8091e
Compare
|
Excellent, thank you @samschott 🍾 |
|
The changes really are minor so I think the PR is good to go. Two test failures which I have noticed seem unrelated:
|
|
Yes, I already saw them from time to time. I merge 💪 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue on macOS where permission changes to a file would not emit a
FileModifiedEvent, unlike other metadata changes. It also moves the classification of metadata changes to a separate methodFSEventsEmitter._is_meta_mod().Edit: This brings FSEvents behaviour in line with Inotify and the winapi.