Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't pass event flag as ID on macOS #725

Merged
merged 1 commit into from Dec 11, 2020
Merged

Don't pass event flag as ID on macOS #725

merged 1 commit into from Dec 11, 2020

Conversation

samschott
Copy link
Contributor

This fixes #723 by properly passing the event ID and not the event flags.

@samschott samschott changed the title Don't pass event flag as ID Don't pass event flag as ID on macOS Dec 10, 2020
@CCP-Aporia
Copy link
Contributor

Thanks again, another great catch! I had fixed this in the python-2.7 branch but missed this in the port.

@BoboTiG BoboTiG merged commit b5c8cc1 into gorakhargosh:master Dec 11, 2020
@BoboTiG
Copy link
Collaborator

BoboTiG commented Dec 11, 2020

Thanks!

@samschott samschott deleted the fix-combining-renamed branch January 5, 2021 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug fsevents-c
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Renamed events are not properly combined on macOS 11
3 participants
@samschott @CCP-Aporia @BoboTiG