Fixes for native fs-events #716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the fix 🍾 FTR I disabled tests for Python 3.6-3.10 as they will be done on master. |
|
Oups, I forgot to tell that the clean-up is already active on the branch. Could you rebase? |
|
Sure, no problem. |
Addresses one possible source of memory corruption, and simplifies the code.
CCP-Aporia
force-pushed
the
fix-issue-702
branch
from
11ef299
to
5142713
Compare
|
I am OK to merge! |
|
I'd first like to figure out the reason for the broken test. It appears to be a regression, and is pretty weird overall. |
Python 2.7 didn't like the double string conversion. Also improve some of the error handling code to behave better, as well as add error handling to th PyCapsule creation.
Inspired by issue gorakhargosh#706
CCP-Aporia
added a commit
to CCP-Aporia/watchdog
that referenced
this pull request
Dec 9, 2020
|
Should be OK to merge now, travis is just slow to get around to all environments. |
BoboTiG
approved these changes
Dec 9, 2020
|
You are a killer :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some fixes and code simplifications for the native fsevents module:
PyBytes_C API, so we can remove a bunch of the#if PY_MAJOR_VERSIONconditionals.NativeEvent(and provides additional ones that weren't exposed so far). This fixes [macOS] Events without "renamed" or "modified" flags are dropped #702 .Alas, the Python 2.7 tests currently fail with an interesting error in
tests/test_fsevents.py::test_unschedule_removed_folderthat I still need to investigate. So this draft PR is primarily to see what the CI says for everything that I cannot test locally.