parser: cmd style check tuple to list #1315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
visualfc
commented
Jul 3, 2022
•
visualfc
commented
Codecov Report
@@ Coverage Diff @@
## main #1315 +/- ##
==========================================
+ Coverage 90.88% 90.89% +0.01%
==========================================
Files 22 22
Lines 8482 8503 +21
==========================================
+ Hits 7709 7729 +20
- Misses 623 624 +1
Partials 150 150
Continue to review full report at Codecov.
|
xushiwei
reviewed
Jul 3, 2022
xushiwei
reviewed
Jul 4, 2022
| for p.tok != endTok && p.tok != token.EOF && !ellipsis.IsValid() { | ||
| list = append(list, p.parseRHSOrType()) // builtins may expect a type: make(some type, ...) | ||
| expr := p.parseRHSOrType(isCmd && len(list) == 0) | ||
| if tuple, ok := expr.(*tupleExpr); ok { |
There was a problem hiding this comment.
Parsing
println (1, 2)*2should return an error.
So, we should check if this statement is ended or not.
xushiwei
reviewed
Jul 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.