New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test issue_78 #81

Merged

inhere merged 1 commit into gookit:master from fishyww:fixes-pointer-field-panic

Jan 19, 2021

Member

fishyww commented Jan 16, 2021

No description provided.


          test issue_78

9fc2b13

coveralls commented Jan 16, 2021

Pull Request Test Coverage Report for Build 207

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 93.209%

Totals
Change from base Build 471274878:	0.0%
Covered Lines:	2553
Relevant Lines:	2739

💛 - Coveralls

coveralls commented Jan 16, 2021 •

edited

Pull Request Test Coverage Report for Build 489397938

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 93.209%

Totals
Change from base Build 471274878:	0.0%
Covered Lines:	2553
Relevant Lines:	2739

💛 - Coveralls

Member Author

fishyww commented Jan 16, 2021 •

edited

@inhere 哈喽~我基于最新的代码拉的分支，写了一份关于 #78 的UT，但是并没有复现panic，想请你一起看一下？
v1.2.5 版本源码有这一行代码：

validate/data_source.go

Line 441 in 6e2dacb

if !fv.IsValid() {

通过go mod 拉取依赖包却没有这一行判断导致panic，你那边会复现此问题吗？

Member

inhere commented Jan 19, 2021

我抽时间也看看

Member Author

fishyww commented Jan 19, 2021 •

edited

问题点就是：
github可以看到这一行代码，但是通过go mod却没有这一行代码导致的panic

inhere merged commit 2e6691d into gookit:master

Member

inhere commented Jan 20, 2021

我发个新版本再让他试试

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment