Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid pointer in stack when stack grows #21

Merged
merged 1 commit into from Dec 18, 2020
Merged

Fix invalid pointer in stack when stack grows #21

merged 1 commit into from Dec 18, 2020

Conversation

mxmauro
Copy link
Contributor

@mxmauro mxmauro commented Aug 18, 2020

Hi,

Starting from Go 1.14.x (if I'm right), unsafe and dll calls changed a bit in the way pointers should be passed.

To reproduce the issue launch a go routine from main and try to output a colorized text.

This is a Windows specific bug.

Regards,
Mauro.

@coveralls
Copy link

coveralls commented Aug 18, 2020

Pull Request Test Coverage Report for Build 113

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.583%

Totals Coverage Status
Change from base Build 112: 0.0%
Covered Lines: 779
Relevant Lines: 815

💛 - Coveralls

@inhere inhere merged commit 05ec68c into gookit:master Dec 18, 2020
@inhere inhere added the enhancement New feature or request label Dec 18, 2020
@inhere inhere linked an issue Dec 18, 2020 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

panic when running on windows with multiple go routines
3 participants