Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocomplete prediction type fields should be optional #1106

Open
samruston opened this issue Dec 6, 2023 · 1 comment
Open

Autocomplete prediction type fields should be optional #1106

samruston opened this issue Dec 6, 2023 · 1 comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@samruston
Copy link

Hi,

The autocomplete response type currently lists types & place_id as required properties:

However according to the docs, these properties are optional:
https://developers.google.com/maps/documentation/places/web-service/autocomplete#PlacesAutocompleteResponse

This caught us off guard recently as we had queries that would not return types, such as Rua ch 13. However I'm not sure under what circumstances a place_id would not be returned. However I believe the types should accurately reflect the response returned.

@samruston samruston added triage me I really want to be triaged. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Dec 6, 2023
@wangela
Copy link
Member

wangela commented Dec 6, 2023

If you would like to upvote the priority of this issue, please comment below or react on the original post above with 👍 so we can see what is popular when we triage.

@samruston Thank you for opening this issue. 🙏
Please check out these other resources that might help you get to a resolution in the meantime:

This is an automated message, feel free to ignore.

@usefulthink usefulthink added priority: p2 Moderately-important priority. Fix may not be included in next release. and removed triage me I really want to be triaged. labels Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

3 participants