Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: GoogleMap in preview early return breaking preview layout #213

Merged
merged 2 commits into from Oct 28, 2022

Conversation

claytongreen
Copy link
Contributor

Fixes #212

@wangela wangela changed the title Fix GoogleMap in preview early return breaking preview layout fix:GoogleMap in preview early return breaking preview layout Oct 20, 2022
@wangela wangela changed the title fix:GoogleMap in preview early return breaking preview layout fix: GoogleMap in preview early return breaking preview layout Oct 20, 2022
Don't return a Composable, just return early
Copy link
Member

@arriolac arriolac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change LGTM. The test failures is due to the Maps API key secret not being copied over from forked PRs

@wangela
Copy link
Member

wangela commented Oct 28, 2022

Thank you for your contribution @claytongreen!

@wangela wangela merged commit 020dd4e into googlemaps:main Oct 28, 2022
googlemaps-bot pushed a commit that referenced this pull request Nov 21, 2022
## [2.7.3](v2.7.2...v2.7.3) (2022-11-21)

### Bug Fixes

* `GoogleMap` in preview early return breaking preview layout ([#213](#213)) ([020dd4e](020dd4e))
@googlemaps-bot
Copy link
Contributor

🎉 This PR is included in version 2.7.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GoogleMap Composable breaks layout in Preview
4 participants