Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for StreetView. #209

Merged
merged 12 commits into from Dec 16, 2022
Merged

feat: Add support for StreetView. #209

merged 12 commits into from Dec 16, 2022

Conversation

arriolac
Copy link
Member

@arriolac arriolac commented Sep 27, 2022

Fixes #177

  • Support all properties on StreetViewPanorama
  • Add sample
  • Add tests

Copy link

@Claveyo1 Claveyo1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

209

@Claveyo1
Copy link

Mándame todo de nuevo recuperar mis mapas

Change-Id: Id7f5b23a2458d77a08422886ef12799ffa0ebe7c
Change-Id: Ie6ee4d41bbef9e9242fc3a33fd53dee8fca2d87a
Change-Id: I8177feadc27d466f39e5d4e8d04b629afd241b4c
Change-Id: I416a77dbba34689d3c60d766bce2429fa3479641
Change-Id: I945630a8e36edea272462fed72ccd1662efcb497
Change-Id: I7f7d0c165cf38738a624a8333c1d8bb35ecbf048
@arriolac arriolac marked this pull request as ready for review October 31, 2022 21:27
@arriolac arriolac requested a review from wangela October 31, 2022 21:27
Change-Id: Ib140373efa7fe265369ff3b81bfe2f9a4b202b24
Change-Id: I0c19a5ec5b716b22bffa05f0c916fb67fca745be
Change-Id: I4121f8774fedb592f0c9d9a86a153f0399bad666
Copy link
Member

@wangela wangela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think docs are generated automatically by bot, but would you add a section to the README about this new feature?

@arriolac
Copy link
Member Author

arriolac commented Dec 9, 2022

I think docs are generated automatically by bot, but would you add a section to the README about this new feature?

Done in e300748

Copy link
Member

@wangela wangela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit, sorry

README.md Outdated Show resolved Hide resolved
@wangela wangela merged commit aabe02c into main Dec 16, 2022
@wangela wangela deleted the chris/feat/177 branch December 16, 2022 03:03
googlemaps-bot pushed a commit that referenced this pull request Dec 16, 2022
# [2.8.0](v2.7.4...v2.8.0) (2022-12-16)

### Features

* Add support for StreetView. ([#209](#209)) ([aabe02c](aabe02c))
@googlemaps-bot
Copy link
Contributor

🎉 This PR is included in version 2.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Street View Composable
6 participants