Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Disable flaky test. #193

Merged
merged 2 commits into from Aug 30, 2022
Merged

chore: Disable flaky test. #193

merged 2 commits into from Aug 30, 2022

Conversation

arriolac
Copy link
Member

@arriolac arriolac commented Aug 18, 2022

Disables flaky test on CI.

I decided to disable it since commits have been landing to main despite the test failing. It's a known env-specific issue and I think disabling this is the right move so that merges aren't accidentally made when a different failure happens. This should be uncommented again and addressed as part of #174.

Change-Id: Ida47c6738972178790a6c519fc444c3e405932bf
Copy link
Contributor

@barbeau barbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@arriolac
Copy link
Member Author

arriolac commented Aug 19, 2022

Looks like the failure is from the test that I just commented out for the pull_request_target run. Not sure why it's not picking up the change in this commit. Note though that the other run-instrumentation-test runs pass so I believe it should be safe to merge this @wangela

image

EDIT: Looks like pull_request_target is WAI. It doesn't actually run the code from the PR commit, but instead, it uses the commit from the target branch. I think this should be removed altogether since the intention for pull_request_target was for it to be run on PRs from forks (which it's not doing).

Change-Id: Ic2e00097b7e34d83f06bf57e06a9a8c08a305531
@wangela wangela merged commit 24f2015 into main Aug 30, 2022
@wangela wangela deleted the chris/chore/174 branch August 30, 2022 20:16
@googlemaps-bot
Copy link
Contributor

🎉 This PR is included in version 2.7.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants