New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Use version catalog for dependency management #185
Conversation
4a6b6f5
to
5b84f6f
Compare
5b84f6f
to
f54882f
Compare
@barbeau There is always one UI test that is failing, it runs green locally. Is it just a flaky test? Or is there something I can do to optimise this? 馃 馃槃 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change looks great btw! It LGTM. Still need to figure out the flaky test but I think this should be good to merge so long as tests pass locally.
# [2.6.0](v2.5.3...v2.6.0) (2022-08-17) ### Features * Use version catalog for dependency management ([#185](#185)) ([b2b33ab](b2b33ab))
馃帀 This PR is included in version 2.6.0 馃帀 The release is available on:
Your semantic-release bot 馃摝馃殌 |
First of all, thanks for an awesome project! 馃ぉ I really like it!
In this PR I have tried to implement version catalog for dependency management. This is important to ensure consistency in library versions across modules.
There are some things to consider. The AGP version is not yet updated (7.0.4) and therefore [version catalog](https://docs.gradle.org/current/userguide/platforms.html) is still experimental. However, since there was a PR onthis (181) I thought this was okay. Then I canrebase and remove theenableFeaturePreview
flag when that is merged. Furthermore, I have notimplementedplugins
inlibrary.versions.toml
as that is a feature that was added in version 7.2 of gradle.Update: Rebased on #181, used plugins from version catalog and updated the root gradle file 馃槃
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #172 馃
Fixes #160 馃